Summary

This pull request addresses the issue of broken links for customfield_textarea embedded files with a context ID of 1, which happens as part of pull request #131 and issue #121. The problem arises because text areas will now assume that any files are located in the course module context. This pull request updates the file table to resolve this issue.

Approach

New records are inserted with the course module context and updated filepathhash rather than updating the old file records. This approach has a few advantages:

1. Backward Compatibility: Existing files fetched by system context will (should) continue to work.
2. Cross-Referencing: New records can be cross-referenced with existing records.
3. Future Cleanup: Old records can be cleaned up at a later date without affecting current functionality.

Testing Instructions

Testing this change is not straightforward but can be done by following these steps:

1. Checkout the MOODLE_401_STABLE branch.
2. Revert pull request #119.
3. Edit an overview section and add some embedded files, such as images.
4. Verify that these files use context ID 1.
5. Unrevert pull request #119.
6. Checkout pull request #131.
7. Verify that the links are broken for the overview section.
8. Checkout this branch and update your Moodle installation.
9. Verify that the same overview section files now display correctly and can be backed up and restored without issue.

Related Issues

• Issue #121
• Pull Request #131

Additional Notes

I recommend backing up your database before applying these changes.
This should probably apply to more than just "overview" sections. What do you think?