[Issue #121] Fix broken embedded file references #138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request addresses the issue of broken links for
customfield_textarea
embedded files with a context ID of 1, which happens as part of pull request #131 and issue #121. The problem arises because text areas will now assume that any files are located in the course module context. This pull request updates the file table to resolve this issue.Approach
New records are inserted with the course module context and updated
filepathhash
rather than updating the old file records. This approach has a few advantages:Testing Instructions
Testing this change is not straightforward but can be done by following these steps:
Related Issues
Additional Notes
I recommend backing up your database before applying these changes.
This should probably apply to more than just "overview" sections. What do you think?